你能帮我优化一个golang代码关于函数CrossPointTwoRect

在Go中，可读性是最重要的.

classic 计算机科学课本的标题是算法+数据 struct =程序.

数据 struct 包括:

type Point struct {
    X, Y int
}

type Rectangle struct {
    P1 Point // Min
    P2 Point // Max
}

算法是:

func CrossPointTwoRects(r1, r2 Rectangle) []Point {
    var crossPoints []Point
    existed := make(map[Point]bool, 0)
    var xs = []int{r1.P1.X, r1.P2.X, r2.P1.X, r2.P2.X}
    var ys = []int{r1.P1.Y, r1.P2.Y, r2.P1.Y, r2.P2.Y}
    for _, x := range xs {
        if r1.P1.X <= x && x <= r1.P2.X && r2.P1.X <= x && x <= r2.P2.X {
            for _, y := range ys {
                if r1.P1.Y <= y && y <= r1.P2.Y && r2.P1.Y <= y && y <= r2.P2.Y {
                    p := Point{X: x, Y: y}
                    if !existed[p] {
                        if crossPoints == nil {
                            crossPoints = make([]Point, 0, 4)
                        }
                        crossPoints = append(crossPoints, p)
                        existed[p] = true
                    }
                }
            }
        }
    }
    return crossPoints
}

https://go.dev/play/p/7gGc5Xsm1xA

一些围棋基准:

func BenchmarkY(b *testing.B) {
    // Y - Intersection
    r1 := Rectangle{Point{1, 1}, Point{4, 4}}
    r2 := Rectangle{Point{2, 2}, Point{3, 3}}
    for i := 0; i < b.N; i++ {
        CrossPointTwoRects(r1, r2)
    }
}

func BenchmarkN(b *testing.B) {
    // N - No intersection
    r1 := Rectangle{Point{1, 1}, Point{4, 4}}
    r2 := Rectangle{Point{8, 8}, Point{9, 9}}
    for i := 0; i < b.N; i++ {
        CrossPointTwoRects(r1, r2)
    }
}

可比基准结果:

rocka2q:
BenchmarkY-12     8445902    142.8 ns/op    64 B/op   1 allocs/op
BenchmarkN-12   120209712     10.12 ns/op    0 B/op   0 allocs/op

zhuohuashiyi:
BenchmarkYZ-12     872277   1376 ns/op     283 B/op  23 allocs/op
BenchmarkNZ-12    1000000   1147 ns/op      51 B/op  16 allocs/op

coxley:
BenchmarkYC-12    5387480    212.2 ns/op    64 B/op   1 allocs/op
BenchmarkNC-12   13633231     82.94 ns/op   64 B/op   1 allocs/op