C++ 在为hashmap创建加载器时，我的存储桶指向它自己

这个问题很愚蠢:在将 node 链接到哈希表之后，您用free(new_word)来释放 node .只要删除此呼叫即可.

另请注意这些备注:

• 不需要分配current_wordarray.只需将其定义为具有自动存储的本地对象.

• 如有错误，切记关闭文件，避免资源泄漏.

• 在出错的情况下返回true(即:1)有点令人困惑.更一致的API应该是返回成功读取的字数，并在出错时返回-1.

• 您应该go 掉存储在current_word中fgets()的尾随换行符.

• 不要对显而易见的事情发表 comments .

以下是修改后的版本:

#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define LENGTH 80
#define HASH_TABLE_LENGTH 1023

typedef struct node {
    struct node *next;
    char word[LENGTH];
} node;

extern int hash(const char *s); // returns a positive value < HASH_TABLE_LENGTH

node *table[HASH_TABLE_LENGTH];

int load(const char *dictionary)
{
    FILE *dict = fopen(dictionary, "r");
    if (dict == NULL)
    {
        fprintf(stderr, "Cannot open dictionary file %s: %s\n",
                dictionary, strerror(errno));
        return -1;
    }

    char current_word[LENGTH];

    int index;
    int count = 0;

    while (fgets(current_word, LENGTH, dict) != NULL)
    {
        node *new_word = malloc(sizeof(node));
        if (new_word == NULL)
        {
            fprintf(stderr, "Error allocating memory.\n");
            fclose(dict);
            return -1;
        }
        // strip the trailing newline if any
        current_word[strcspn(current_word, "\n")] = '\0';
        strcpy(new_word->word, current_word);
        // link the new word at the head of the hash table slot list
        index = hash(new_word->word);
        new_word->next = table[index];
        table[index] = new_word;
        count++;
    }
    fclose(dict);
    return count;
}

// For illustration, here is the code to free the hash table:
void free_hash_table(void) {
    for (int index = 0; i < HASH_TABLE_LENGTH; i++) {
        while (table[index] != NULL) {
            node *p = table[index];
            table[index] = p->next;
            free(p);
        }
    }
}